Trigger onExecuteAction for Toggle Visibility Action #7172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwoo-msft
requested changes
Mar 30, 2022
ghost
added
the
jwoo-msft
approved these changes
Mar 30, 2022
Contributor
Author
|
Sorry, @jwoo-msft for some reason did not get your updated comment and added the spacing fix. Should I add it again? |
Contributor
fixed it for you:) |
paulcam206
approved these changes
Apr 5, 2022
michaelfarnsworth
pushed a commit
to michaelfarnsworth/AdaptiveCards
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6742
Issue was fixed by adding super.execute() at the beginning of the ToggleVisibilityAction.execute() implementation, per David's recommendation on the issue. This will make the ToggleVisibilityAction trigger the onExecuteAction event.
Microsoft Reviewers: Open in CodeFlow